search

scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.59k stars 840 forks source link

Inconsistent appearance of "Confirm your email" banner #1044

Open jwzimmer-zz opened 7 years ago

jwzimmer-zz commented 7 years ago

Firefox 49.0.2, Mac OS 10.11, Staging (possibly also on Production; I haven't checked yet)

For user sldwgqds7889, I noticed that the confirm your email banner is showing up on the homepage (www) and profile page (scratchr2), but not on about (www) or the new TTT (/go) page (www). Presumably the banner should appear across all the pages until dismissed (and then it should disappear from all the pages).

captura de pantalla 2016-11-18 a las 10 52 02 pm captura de pantalla 2016-11-18 a las 10 57 44 pm
mewtaylor commented 7 years ago

This is in production – we have the banner tied to the splash page in www, rather than to the nav bar, which means it'll only appear on the splash page, rather than anywhere there's an nav bar.

So, this is definitely a bug, but probably not blocking the deploy IMHO.

jwzimmer-zz commented 7 years ago

Removed staging label since it happens on both staging & production (thanks @mewtaylor).