search

scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.59k stars 839 forks source link

Join Studio dialog in a RTL language should move the X to the left side of the dialog #1844

Open BryceLTaylor opened 6 years ago

BryceLTaylor commented 6 years ago

Expected Behavior When you set the language to a Right to Left language (i.e. Arabic) and you click Join Scratch (انضم إلى سكراتش), the header for the dialog that pops up should have the text on the right and the x icon that closes the dialog on the left.

Actual Behavior The X appears on the right side and overlaps the text. Arabic_Join_www.png

In Scratchr2 the x appears on the left side: arabic_Join_scratchr2.png

Reproduction Steps

  1. Go to the homepage while signed out
  2. Change the language to Arabic ( العربية )
  3. Click Join Scratch in the header ( انضم إلى سكراتش )
  4. Note the x and the text both appear on the right side of the dialog header.
LiFaytheGoblin commented 6 years ago

Is this solved?