Text over 500 letters can be typed into comment

scratchfoundation / scratch-www

Standalone web client for Scratch

https://scratch.mit.edu

BSD 3-Clause "New" or "Revised" License

1.58k stars 834 forks source link

Text over 500 letters can be typed into comment #2742

Open apple502j opened 5 years ago

apple502j commented 5 years ago

When I typed a lot of letters into comments, I saw "-264 characters left". It shouldn't let users type more than 500.

Steps to Reproduce

Paste long sentences or type.

Operating System and Browser

Windows 7/Firefox 65

Reports by community: mitaku115 https://scratch.mit.edu/discuss/post/3417339/ (env unknown)

joker314 commented 5 years ago

It's a really useful feature that Twitter also has, and I believe this is by design, for it allows you to rephrase your comment without deleting what you've spent time to write.

(Unless you're actually able to submit the comment?)

apple502j commented 5 years ago

At least it should tell the user that the text is over 500 before clicking Send.

joker314 commented 5 years ago

At least it should tell the user that the text is over 500 before clicking Send.

I agree. I think negative numbers should show up in red, and the comment box itself should maybe also become red (or orange if red is too scary), and some kind of warning should maybe show up.

But it's not high priority because when you do hit "Send", it doesn't delete your comment, you can still fix it without losing your work

thisandagain commented 5 years ago

As others have noted, we believe that the current functionality is more intuitive and helpful than having a "hard stop" on the input field. That said, I agree that the "-X characters left" text is likely too subtle.

/cc @carljbowman @kathymakes

carljbowman commented 5 years ago

Totally agree on allowing more characters than 500 for ease of editing.

Giving more apparent feedback is certainly something we should have. There was a dependency to port over the "tooltip" component. But Good news, that was apart of the Cleanspeak field validation work.

An alternative that does not use a tooltip, similar to @joker314 suggestion

One thing that's nice about the tooltip, while it may feel redundant, is that it displays the max of 500. This way you know how much editing needs to be done to the comment. An alternative would be adding "/500" to the "character count.

thisandagain commented 5 years ago

Thanks @carljbowman. My leaning is to go with the option that does not use a tooltip for now and then add a tooltip should we continue to see issues / confusion.

carljbowman commented 5 years ago

@thisandagain - Sounds good. Keep it simple.