search

scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.6k stars 847 forks source link

Need to update the iso-3166-2 package #6020

Open chrisgarrity opened 3 years ago

chrisgarrity commented 3 years ago

In teacher account signup (and perhaps other places) we depend on an iso-3166 package to provide a list of the states or provinces for a particular country: https://github.com/LLK/scratch-www/blob/2903f855aeb9733cf03479e8adc8ea83891d4937/package.json#L100

This library has not been updated in 4 years, and appears to be looking for a maintainer.

We should evaluate and pick an alternative (maintained) package. With just a quick search we found:

This was brought to our attention by someone trying to sign up for a teacher account in Cyprus, where the province data is incorrect.

Note that while the provinces are the immediate need, these packages usually include countries as well: iso3166-1. So we wouldn't need to maintain our own list of countries.

BryceLTaylor commented 3 years ago

Related to https://github.com/LLK/scratch-www/issues/4024

ghost commented 2 years ago

North Macedonia, which changed its name in 2019, is also still called "Macedonia, the Yugoslavian republic". I did an issue on this (#5691) but was closed for being a duplicate (despite me making that topic first...)

Just wanted to bring this up.

ghost commented 2 years ago

Looks good when you join an account; Korea republic is repeated 2 times though, as shown in this image:

Accio1 commented 2 years ago

Looks good when you join an account; Korea republic is repeated 2 times though, as shown in this image:

@derter-menter, the Republic of Korea is different than the Democratic People's Republic of Korea. The Republic of Korea is South Korea whereas the Democratic People's Republic of Korea is North Korea.