search

scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.59k stars 840 forks source link

CE-215 On mobile, important navigation links are only partially visible #6743

Open nasirkhan opened 2 years ago

nasirkhan commented 2 years ago

Expected Behavior

On a mobile browser it should display a mobile optimized navigation, may be a hamburger menu.

Actual Behavior

Top nav only displays 3 menu item and half of an another item.

Steps to Reproduce

Go to https://scratch.mit.edu from Google Chrome or Firefox from your mobile and you may see the partial top nav.

I have seen this issue in the homepage, about page and some other pages.

System Details

Device: Google Pixel 6 Browser: Google Chrome, Mozilla Firefox

Screenshots Screenshot_20220302-200203

Screenshot_20220302-200255

moeenio commented 2 years ago

Similar to #2243.

This has always been bothering me. What would be the preferred solution? I'm willing to try and make a PR for this issue.

nasirkhan commented 2 years ago

4 years gone for https://github.com/LLK/scratch-www/issues/2243 still the issue exists! whereas i was frustrated that about 4months gone and no one cares about this issue of the homepage of the website

SeansC12 commented 2 years ago

I am also willing to try and fix this issue. However, since there seems to be insufficient space to fit one of the header links, how should we approach this? Reorganising/redesigning the navbar (for mobile) may be needed. @benjiwheeler, what do you think? What would be the preferred solution?

nasirkhan commented 2 years ago

@SeansC12 there is not much to think about the top navigation area. millions of websites following the same hamburger style menu for the mobile view. We can just follow that without thinking too much

SeansC12 commented 2 years ago

@nasirkhan however a hamburger styled menu can have variation in design. Do we need to confirm with @benjiwheeler with the new hamburger styled design before proceeding?