scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.59k stars 841 forks source link

Copy embed link returns a false positive. #7193

Open Paul-Clue opened 1 year ago

Paul-Clue commented 1 year ago

Where To Find Bug

/projects

Expected Behaviour

When the screen reader clicks on the “Copy Link” or “Copy Embed” links in the Copy Link modal, the user should receive an auditory notice that the link or code has been copied.

Actual Behaviour

When the screen reader user navigates to the “Copy Link” or “Copy Embed” links, they receive auditory cues indicating that the user has already copied the link or code before actually clicking on anything. This is because the “Copied” success message is not properly hidden from the screen reader The content is only hidden in css by setting the opacity to 0. Instead, toggle the display or visibility properties. Or, only render the success message after the “Copy Link” text has been clicked and use an ARIA alert role to announce the “Copied” success message.

Steps To Reproduce

Screenshot

Screenshot 2022-12-19 at 5 47 54 PM

System Details macOs Ventura, Chrome Browser, Firefox, VoiceOver (AT)

Bashamega commented 1 year ago

It is working perfectly fine for me

Paul-Clue commented 1 year ago

@Bashamega. Our accessibility tester made it more clear to us what was happening. The issue has been updated.