scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.58k stars 834 forks source link

Add a site-wide dark mode #7333

Open ajskateboarder opened 1 year ago

ajskateboarder commented 1 year ago

This is simply a feature request to add dark mode to places outside of the editor through the device theme or as a toggle in the navbar.

Potential dark mode made with edits made to src/_colors.scss:

People on the discussion forums have been asking for this feature (link) for many years and the topic is going strong at 130+ pages. Many modern sites have a dark mode, and much of the Scratch community would appreciate the feature.

While you can use an extension or userscript, discussion of these things in the forums are banned and a native solution is still preferred by most.

I know a dark mode is a simple aesthetic change which could have whatever priority, but this would finally end so many requests from the users and everyone would be satisfied.

This should only be added to finished 3.0 pages for consistency, and can be introduced to newly migrated pages. The editor already has a feature request here, but this is for the whole site.

tonyzhigit commented 1 year ago

Maybe create a web page to let the users customize the page's colour?

ajskateboarder commented 1 year ago

Maybe create a web page to let the users customize the page's colour?

I don't know, doesn't it sound a little excessive for Scratch? It would also require a lot of modification to the CSS to work consistently across pages. Thanks, but dark mode should be good for now.

The requests for dark mode are certainly higher than custom theming at the moment.

showierdata9978 commented 1 year ago

I agree dark mode needs to be added before custom theming

veloce-vasta commented 1 year ago

Has the ST not noticed the threads before this was made??

ajskateboarder commented 1 year ago

Has the ST not noticed the threads before this was made??

Well, we would have some kind of status regarding dark mode at this point, so they probably just look it over.

Secret-chest commented 1 year ago

Wouldn't custom themeing go with this? Adding dark mode implies making the CSS use custom properties

showierdata9978 commented 1 year ago

Wouldn't custom themeing go with this? Adding dark mode implies making the CSS use custom properties

no, not really. all dark mode wold do is change the colors to be more dark...

veloce-vasta commented 1 year ago

This got noticed!!!

Secret-chest commented 1 year ago

Wouldn't custom themeing go with this? Adding dark mode implies making the CSS use custom properties

no, not really. all dark mode wold do is change the colors to be more dark...

Yes, and by doing that you change the colours in the CSS so why not add custom colours.

showierdata9978 commented 1 year ago

Wouldn't custom themeing go with this? Adding dark mode implies making the CSS use custom properties

no, not really. all dark mode wold do is change the colors to be more dark...

Yes, and by doing that you change the colours in the CSS so why not add custom colours.

because dark mode is easier to implement, and only a single extra button is needed to do it lmao

showierdata9978 commented 1 year ago

Alot more logic is required for EVERY SINGLE SCRATCH USER

Dark mode is a single if statement, and a single cookie.

On Wed, Jan 25, 2023, 12:58 PM Secret-chest @.***> wrote:

Wouldn't custom themeing go with this? Adding dark mode implies making the CSS use custom properties

no, not really. all dark mode wold do is change the colors to be more dark...

Yes, and by doing that you change the colours in the CSS so why not add custom colours.

— Reply to this email directly, view it on GitHub https://github.com/LLK/scratch-www/issues/7333#issuecomment-1404091105, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQHW4PYW47VXGHMXTYXCXM3WUFZUHANCNFSM6AAAAAATXLAP5U . You are receiving this because you commented.Message ID: @.***>

ajskateboarder commented 1 year ago

The difficulty of changing the site colors cannot be understated. It takes a minute to build it in development, thanks to Webpack (should really switch to Vite LOL), and all the color changes you make have to be WCAG-compliant. It really is kind of a pain

ajskateboarder commented 1 year ago

I will close this for now, feel free to reopen it whenever necessary

ajskateboarder commented 1 year ago

Bump

659in commented 11 months ago

I see this as a win (I am 56-s)

teamsonic2011 commented 10 months ago

Support, light mode hurts my eyes. Wait how does GitHub work