scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.6k stars 847 forks source link

Browse Project Button Shows Unshared Projects #8221

Open leahcimto opened 7 months ago

leahcimto commented 7 months ago

Expected Behavior

When click browse projects, you should see projects that are shared that you can add.

Actual Behavior

Users can see unshared projects that they favorited, (which means that it includes projects that break the community guidelines that were unshared!).

Steps to Reproduce

Steps to reproduce the behavior:

  1. Favorite a project on an alt account
  2. Unshare the project
  3. Try to add it to a studio with the browse projects button
  4. Notice that it is displayed there, but when you click it it isn't added because it is unshared

System Details

Doesn't matter, but macOS 14.1, Firefox 124.0.1

Screenshots Screenshot 2024-03-30 at 2 44 45 PM

When clicked: Screenshot 2024-03-30 at 2 47 46 PM

blazgocompany commented 4 months ago

I think I fixed it but I don't know how to test it.