scratchfoundation / scratch-www

Standalone web client for Scratch
https://scratch.mit.edu
BSD 3-Clause "New" or "Revised" License
1.59k stars 836 forks source link

Create New Modal Component #980

Closed mewtaylor closed 7 years ago

mewtaylor commented 7 years ago

We currently use react-modal to handle some of our modal elements, however it would be nice to have our own modal that can be a bit more customizable to the use cases we need it for. See #979 for a specific, new modal use case. The design for this modal needs to include the following elements:

Needs a mobile design as well

carljbowman commented 7 years ago

r2 0_modal

r2 0_modal grid

kaschm commented 7 years ago

Global content for modal:

Tutorial: Find out how to make this project using a step-by-step tutorial in Scratch.

Activity Cards: Explore new coding ideas using this set of illustrated cards you can print out.

Educator Guide: Use this educator guide to plan and lead a one-hour Scratch workshop.

ntlrsk commented 7 years ago

(Note: we updated the text above.)

carljbowman commented 7 years ago

@ntlrsk - What do you think of the banner images?

Animate Your Name animate-your-name-banner

Make it Fly make-it-fly-banner

Make Music make-music-banner

Race to the Finish race-to-the-finish-banner

Hide and Seek hide-and-seek-banner

Create a Story create-a-story-banner

Fashion Game fashion-game-banner

Pong Game pong-game-banner

Let's Dance lets-dance-banner2

Catch Game catch-game-banner

Virtual Pet virtual-pet-banner

ntlrsk commented 7 years ago

Those look great! The two I had questions about are Let's Dance and the Story one. (1) For dance I wonder if it would be good to show different poses of the same dancers (like how Pong has animation)? (2) And for story either totally different characters each time, or more of a story progression? I can provide if that's helpful!

carljbowman commented 7 years ago

@ntlrsk - Thanks for the notes.

1) Let's Dance - Did you have particular dance poses or sequence in mind? 2) Create a Story - Awesome! Would you mind providing the 3 frames?

Super easy to update!

ntlrsk commented 7 years ago

Here's a possibility for dance as one big image - Champ99 in four dance positions across (right now one is hidden in this project): https://scratch.mit.edu/projects/129601771/#editor Similar to this: image

ntlrsk commented 7 years ago

Or if we want the Dance project to look more like the sample project, a similar idea but with our other character ( like this https://scratch.mit.edu/projects/129516330/#editor )

image

ntlrsk commented 7 years ago

For Story how about these three (which we use on the cards):

story1 story3 story4

Or are they too different?

carljbowman commented 7 years ago

@ntlrsk - I updated my previous comment

1) Let's Dance - There are two versions V1 with Champ & V2 with Jo. Let me know if you have a preference. 2) Create a Story - We tried to avoid using text in the images for translation purposes, so I did not include the speech bubble. 3) Animate Your Name - As we discussed yesterday, I changed the name from 'Scratch' back to 'Ana'.

ntlrsk commented 7 years ago

@carljbowman Let's go with Jouvi for the dancer They all look good!

ntlrsk commented 7 years ago

One more minor question -was wondering whether to have the medium haircut for the Fashion Game. Excited to see these on the site!

mewtaylor commented 7 years ago

Implemented in https://github.com/LLK/scratch-www/pull/1008