search

scratchfoundation / scratchwikiskin

Skin for the Scratch wiki
15 stars 20 forks source link

Call printTrail() #10

Closed tjvr closed 11 years ago

tjvr commented 11 years ago

From the docs:

Output the basic end-page trail including bottomscripts, reporttime, and debug stuff.

This should be called right before outputting the closing body and html tags.

Fixes the ScratchBlocks2 extension.

@jacob-g I reverted to unix line endings for consistency with the other files.

seotts commented 11 years ago

Thanks for all your help! I'm testing this out and I can't seem to get it to work-- the text in the tag just looks like any other text in a 

 tag. Any hints for getting this to run?
tjvr commented 11 years ago

the text in the tag just looks like any other text in a tag.

I don't understand what you mean.

The fix worked for me...

lightnin commented 11 years ago

Hmm - it looks like the mw-blocks extension we cloned has the actual blocks code as a git submodule or something? I'm not sure what the little folder-icon thingy means on github.

Does that update automatically when you make changes to the scratchblocks submodule?

I'm wondering if we are running different versions of some parts of the code..

Sarah - the first thing to do is to get rid of your own clone of the scratchblocks extension and use the LLK one, so we can try to avoid getting confused.

seotts commented 11 years ago

I switched over to the LLK one, still no luck.

And oops, didn't realize my html was rendering in comments here. I meant "the text in the < scratchblocks > tag just looks like any other text in a < pre > tag."

tjvr commented 11 years ago

@Lightnin Yes, it's a git submodule. As I understand it, it doesn't auto-update when I change the scratchblocks2 repo. Your copy will have the submodule at the same commit as mine.

tjvr commented 11 years ago

Having just written 200 words describing my fruitless attempts at investigation, I found the bug: scratchblocks2.js is missing.

I'm guessing this could be because I switched to using git submodules? So you need to git clone --recursive.

seotts commented 11 years ago

Ah, excellent. Thanks for figuring that out.