search

scratchfoundation / scratchwikiskin

Skin for the Scratch wiki
15 stars 20 forks source link

Scratchblocks plugin #3

Closed tjvr closed 11 years ago

tjvr commented 11 years ago

The Scratchblocks plugin doesn't seem to load on this skin. I'm not sure why.

tjvr commented 11 years ago

I think the skin isn't loading the JS (or maybe CSS) from ResourceLoader like it should be.

lightnin commented 11 years ago

I think that's likely! Importing the js was broken for a while - possibly the strategy for doing it was left over from the version of the skin from pre-resource loader days. Since it was kind of hacked into the future, it's not too surprising that it's not done according to the latest wikimedia recommendations.

Can you or jvvg try refactoring that to use resource loader?

On Thu, Jun 13, 2013 at 5:52 AM, blob8108 notifications@github.com wrote:

I think the skin isn't loading the JS (or maybe CSS) from ResourceLoader like it should be.

— Reply to this email directly or view it on GitHubhttps://github.com/LLK/scratchwikiskin/issues/3#issuecomment-19382216 .

tjvr commented 11 years ago

I think resource loader is working now — see #10.