search

scratchfoundation / scratchwikiskin

Skin for the Scratch wiki
15 stars 20 forks source link

May I suggest here? Add the Scratch Wiki favicon to the skin #34

Closed rumanti closed 9 years ago

rumanti commented 9 years ago

It would be very helpful if the code for adding favicon is included in this repository. I don't have enough PHP experience to do this myself. Please consider this.

Also, if suggestions are not acceptable in the Issues section, please tell me where I can suggest things so that I may avoid this mistake in the future. Thanks!

maxamillion40 commented 9 years ago

You can suggest here or post them on my Scratch account. I don't think adding the favicon code is really a big issue.

rumanti commented 9 years ago

Yeah, I know. But I'm remaking the skin (https://github.com/Rumanti/ScratchIndoWiki-Skin) for Indonesian Scratch Wiki, and it would be nice to add the favicon right now, before I actually send the skin code to the DACH Scratch Wiki team. I don't want to bother them by making them updating frequently.

maxamillion40 commented 9 years ago

I don't know what the code is then. Sorry.

rumanti commented 9 years ago

After this months, I found out that the favicon should be set up in LocalSettings.php and not in the skin. My mistake.