search

scratchfoundation / scratchx

Scratch Extension Site
https://github.com/llk/scratchx
190 stars 121 forks source link

Most images are missing an alt attribute #138

Closed kerrtravers closed 6 years ago

kerrtravers commented 6 years ago

When looking through the code for the homepage and extensions page, I noticed that most of the extension images don't have an alt attribute.

trafort commented 6 years ago

It's not really important, The alt is just to put a text to show if the image is not loading. But in your case, it could be important, to tell the user, the image is not loading. :)

kerrtravers commented 6 years ago

@trafort Yeah, it also would be important if a scratch user (or somebody else that came across the site) was using text to speech on the page.

trafort commented 6 years ago

True, you click the image sometimes to go the project, if they see the alt word, they know what it is. :D

thisandagain commented 6 years ago

Thanks @vutondesign. Good catch. This is important for accessibility. In your PR I would prefer to simply use the name of the extension rather than "name of extension Thumbnail".

trafort commented 6 years ago

He was just testing some things in his commit, I made the PR and he told me @thisandagain

kerrtravers commented 6 years ago

@thisandagain No Problem, I will do 😃

I've just noticed that a link to the main Scratch website is HTTP and not HTTPS, would you like me to throw that into this PR or make a separate issue for that?

thisandagain commented 6 years ago

You can include it in this PR. Having it in a separate commit would be good though. Thanks for asking. On Sat, Dec 30, 2017 at 12:28 PM Kerr Travers notifications@github.com wrote:

@thisandagain https://github.com/thisandagain I've just noticed that a link to the main Scratch website is HTTP and not HTTPS, would you like me to throw that into this PR or make a separate issue for that?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/LLK/scratchx/issues/138#issuecomment-354557871, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtoebQKAzDxvfjCpsAXrXFRj8QLOJxVks5tFnLEgaJpZM4RPn8p .

kerrtravers commented 6 years ago

Okay 👍