@magland this is the code I had to send earlier yesterday, ended up being very similar to what you're doing in the other PR, so I'm pointing to that branch. The differences here are:
we use an env var PROTOCAAS_GENERATE_SPEC to avoid raising import error, which is set here
py extension on main.py
I noticed that you changed the convention from app_image to app_container. I believe that to be strictly consistent, we should keep that as app_image, because in fact it's the handle of the image, the bundle that is published, that we're passing in those args. Containers will be the local instantiations of that image running a specific command, and these can have different names, usually related to a run id.
@magland this is the code I had to send earlier yesterday, ended up being very similar to what you're doing in the other PR, so I'm pointing to that branch. The differences here are:
PROTOCAAS_GENERATE_SPEC
to avoid raising import error, which is set heremain.py
I noticed that you changed the convention from
app_image
toapp_container
. I believe that to be strictly consistent, we should keep that asapp_image
, because in fact it's the handle of the image, the bundle that is published, that we're passing in those args. Containers will be the local instantiations of that image running a specific command, and these can have different names, usually related to a run id.Let me know what you think.