search

scratchyone / wasm-sockets

A rust WASM-specific websocket library
MIT License
31 stars 3 forks source link

Include CloseEvent in on_close call #3

Closed vpzomtrrfrt closed 1 year ago

vpzomtrrfrt commented 2 years ago

Resolves #2, though this is a breaking change

scratchyone commented 2 years ago

Sorry, just saw this now. This looks great, I'll test this and make sure all the examples still work with this change, but the CloseEvent info should definitely be available. This seems worth a breaking change to me.

extrawurst commented 1 year ago

@scratchyone any updates on reviewing, merging and releasing this?

scratchyone commented 1 year ago

Thank you so much for your contribution @vpzomtrrfrt, and thanks @extrawurst for reminding me to review it haha. I'll work on some other changes and then publish this as v1.0.0.

scratchyone commented 1 year ago

v.1.0.0 including this PR is available on crates.io now.