search

scravy / waitfor-maven-plugin

Wait for a URL to become available
BSD 2-Clause "Simplified" License
7 stars 4 forks source link

Add support for "redirect" #11

Closed dadoonet closed 2 years ago

dadoonet commented 2 years ago

We add a support for redirect option (default to true).

The redirect flag allows following or not the 302 REDIRECT response. Set it to false to avoid redirect. If a redirect is sent by the server, the statusCode will be 302.

scravy commented 2 years ago

@dadoonet I reviewed. Can you anyways please rebase as I merged #10 . I don't think this new behavior for following redirects (which surely is good to have) should be the default as it might break existing usage.

dadoonet commented 2 years ago

I rebased.

The default behavior for the http client is to follow the redirects. This change basically should not break the current behavior.

scravy commented 2 years ago

Thanks!

I see, so I got that wrong 😬 all the better to get this feature in 😀

dadoonet commented 2 years ago

@scravy I don't think I saw a release with #10 and #11. Are you planning to do one?

scravy commented 2 years ago

@dadoonet I hadn't done one yet. It's released now: https://repo.maven.apache.org/maven2/de/scravy/waitfor-maven-plugin/1.4/