search

scravy / waitfor-maven-plugin

Wait for a URL to become available
BSD 2-Clause "Simplified" License
7 stars 4 forks source link

Disable HttpClient automatic retries #4

Closed dadoonet closed 4 years ago

dadoonet commented 4 years ago

We want to disable the automatic retries mechanism brought by HttpClient and use instead the internal retry that has been written. That way we will first be less verbose even when we set quiet to true but we will make sure we are using the code that has been written to do the checks.

scravy commented 4 years ago

As this would change existing behavior, maybe this should be configurable.

dadoonet commented 4 years ago

I'm not sure this is changing the current behavior. We "just" let your plugin do the "retry" job. But if you prefer I add a new option, let me know. What would be a good name for it? <httpclient_retry>false</httpclient_retry> ( true by default )?

scravy commented 4 years ago

@dadoonet I have transferred this repository from simplaex/ to scravy/ and I will release this plugin with new maven coordinates shortly.

scravy commented 4 years ago

@dadoonet Your changes have been published as

    <groupId>de.scravy</groupId>
    <artifactId>waitfor-maven-plugin</artifactId>
    <version>1.3</version>

Thank you for your contribution!

dadoonet commented 4 years ago

Great! Thanks for releasing it. 😉