scrdest / UristMcStation

Urist McStation's BS12 branch. Come play at byond://24.240.44.164:59359
GNU Affero General Public License v3.0
0 stars 1 forks source link

help i am stuck in a github factory and i can't get out #41

Closed EyesNoEyes closed 8 years ago

Glloyd commented 8 years ago

Only gave it a quick look but the code looks alright. What's with the commented out shotgunrevolver at the bottom? I'd prefer if you didn't commit large amounts of commented out code along with something.

Also, I still think the rifle would be better if it had a chance to explode on firing. Wouldn't be too hard to add, just add a check to the fire proc for this gun that gives it a small probability of exploding and damaging the user, like how guns explode in clowns hands. If you want to get really intense, a better way would be to give it a durability rating that decreases every time you fire. The lower it is, the higher chance of it exploding when you fire. I dunno, just tossing ideas out here.

scrdest commented 8 years ago

This rifle is pretty well balanced as it is, from what I've seen. It's an absolute assload of work to make, and is inferior in every way to both the crossbow and any station weapon.

Also, I am starting a new Baymerge immediately after this one goes live so that crap does not accumulate, and so I'd rather not maintain/have to coerce @EyesNoEyes into maintaining this. It's bad enough with TGameCo's code being shunted on the rest of us to maintain.

Glloyd commented 8 years ago

The thing is, projectile weapons are incredibly deadly, and even as slow and shoddy as this one is, it does mean that projectile weapons would be democratised in a sense. Even if it was a small chance (2-3%) I would feel better about it, and that's not something that would be too hard to maintain because you could probably add it into the special checks proc, which is already being affected here.

On Tue, Sep 20, 2016 at 1:15 PM, scrdest notifications@github.com wrote:

This rifle is pretty well balanced as it is, from what I've seen. It's an absolute assload of work to make, and is inferior in every way to both the crossbow and any station weapon.

Also, I am starting a new Baymerge immediately after this one goes live so that crap does not accumulate, and so I'd rather not maintain/have to coerce @EyesNoEyes https://github.com/EyesNoEyes into maintaining this. It's bad enough with TGameCo's code being shunted on the rest of us to maintain.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scrdest/UristMcStation/pull/41#issuecomment-248368317, or mute the thread https://github.com/notifications/unsubscribe-auth/ADyvWJns6SVRHw2Bpwil7n5myoK3KgDBks5qsBSngaJpZM4KBt8e .

Graham Lloyd

scrdest commented 8 years ago

We already have the crossbows. Which need a serious nerf anyway, and are easier to build and use in every single way, are silent, use absolutely ubiquitous ammo that can be effectively unlimited with a 50 steel sheet, and can pin people to goddamn walls.

EyesNoEyes commented 8 years ago

Right, I'll address the issues now I suppose.

Firstly the ammo this gun uses, 762, only does 25 damage with a penetration quality of 1. With even basic armor the gun is more likely to leave a bruise than a puncture or shrapnel, and even without armor it's unlikely the 3 round magazine could kill someone outright assuming none of them jam or miss, which is in itself not terribly likely.

As well, as @scrdest mentioned, the crossbow is something that's been on the server for ages deserving a serious nerf. This gun, I honestly feel, is the solution to the crossbow problem. The crossbow is silent, quick, easy, and inconspicuous to build, ammo is literally everywhere, and it can blow unarmored heads up in one shot without leaving a brain. This improvised rifle provides a fairly useful ranged improvised weapon that won't do something like blow someone's head up, which is something I've done entirely accidentally with the crossbow, partially the reason I was inspired to make this.

Regarding your backfire/explosion suggestion, I think this weapon is enough of a liability to use already. It makes much much more noise than most ranged weapons, and has noises for every stage of construction. The ingredients are rare and people will notice if things like library shelves or wooden tables go missing, let alone the stacks of plasteel.

Glloyd commented 8 years ago

Good points from both of you. Fair enough, the implementation is good enough as is.

On Tue, Sep 20, 2016 at 6:29 PM, EyesNoEyes notifications@github.com wrote:

Right, I'll address the issues now I suppose.

Firstly the ammo this gun uses, 762, only does 25 damage with a penetration quality of 1. With even basic armor the gun is more likely to leave a bruise than a puncture or shrapnel, and even without armor it's unlikely the 3 round magazine could kill someone outright assuming none of them jam or miss, which is in itself not terribly likely.

As well, as @scrdest https://github.com/scrdest mentioned, the crossbow is something that's been on the server for ages deserving a serious nerf. This gun, I honestly feel, is the solution to the crossbow problem. The crossbow is silent, quick, easy, and inconspicuous to build, ammo is literally everywhere, and it can blow unarmored heads up in one shot without leaving a brain. This improvised rifle provides a fairly useful ranged improvised weapon that won't do something like blow someone's head up, which is something I've done entirely accidentally with the crossbow, partially the reason I was inspired to make this.

Regarding your backfire/explosion suggestion, I think this weapon is enough of a liability to use already. It makes much much more noise than most ranged weapons, and has noises for every stage of construction. The ingredients are rare and people will notice if things like library shelves or wooden tables go missing, let alone the stacks of plasteel.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scrdest/UristMcStation/pull/41#issuecomment-248454519, or mute the thread https://github.com/notifications/unsubscribe-auth/ADyvWApC0wW_azn9sVrItkUA7vEuUyKtks5qsF5OgaJpZM4KBt8e .

Graham Lloyd

scrdest commented 8 years ago

Looks about right. :+1:

Glloyd commented 8 years ago

Yeah, I looked over it and can't see anything wrong. :+1:

On Tue, Sep 20, 2016 at 7:18 PM, scrdest notifications@github.com wrote:

Looks about right. 👍

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scrdest/UristMcStation/pull/41#issuecomment-248464795, or mute the thread https://github.com/notifications/unsubscribe-auth/ADyvWEzP2mxrBbghl0kIKD0dINiKExK_ks5qsGmvgaJpZM4KBt8e .

Graham Lloyd