Easier user classes - Githubissues

scream78 / oauth

Automatically exported from code.google.com/p/oauth

0 stars 0 forks source link

Easier user classes #124

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

I have build some classes to make it easier to use this client lib.

See test client as example.

Original issue reported on code.google.com by michiele...@gmail.com on 22 Sep 2009 at 1:16

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by leah.culver on 25 Sep 2009 at 5:38

Added labels: Lib-PHP, Type-Enhancement

GoogleCodeExporter commented 9 years ago

Original comment by morten.f...@gmail.com on 1 Mar 2010 at 7:16

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Hi,

I've looked at the code today, and while I admire the purpose these files serve 
I cannot recommend them for 
inclusion in the official repository in their current form. 
There is quite a few coding issues I would like to have resolved, a bit of 
terminology-mixup and possibly a 
few bugs as well.. I would also like to see Unit tests of the class so any 
changes can be checked for regression 
etc..

If you would like to make the necessary changes to get the class ready for 
inclusion, please contact me either 
directly on email, on #oauth on Freenode's IRC server or via the oauth-php 
mailing list.

Hope I don't discourage you from future contributions - it really is decent 
work but it just needs a bit more 
work to fit in with the rest of the library.

Regards,
Morten

Original comment by morten.f...@gmail.com on 2 Mar 2010 at 7:46

GoogleCodeExporter commented 9 years ago

Hello Morten, I will contact you on IRC about this. You don't discourage me. As 
well
as I saw some as well, and I thoughed I should wait for patches, when the first 
part
was included.

I appreciate some feedback of the code. I do hope these classes or similar 
ones, will
be included in the project, because OAuth seems rather complex for beginners, 
who
don't know the protocol.

I saw already some bugs in proper_parse_str. I will contact you about this.

Original comment by michiele...@gmail.com on 2 Mar 2010 at 8:17

GoogleCodeExporter commented 9 years ago

Super. I'm usually online on IRC in the daytime of Europe. 

And I agree - some sort of wrapper-functionality to hide a bit of the scariness 
that is OAuth.php for beginners 
might be good. But it's a delicate balance to make sure it's flexible enough to 
do most things while still being 
easy to use.

Original comment by morten.f...@gmail.com on 2 Mar 2010 at 8:22