screego / server

screen sharing for developers https://screego.net/
https://app.screego.net
GNU General Public License v3.0
7.62k stars 551 forks source link

TLS Options cannot be configured #126

Closed EnriqueHernandezL closed 2 years ago

EnriqueHernandezL commented 2 years ago

https://github.com/screego/server/blob/9735e1d3c91a19c4880ccadc0ed9656379c128a7/server/server.go#L28

It is hard coded that the server the default TLS options of http.server are applied. I would like to be able to configure stuff like TLS Versions (since the default ones include deprecated versions), see for example

  srv := &http.Server{
    Addr:    *addr,
    Handler: mux,
    TLSConfig: &tls.Config{
      MinVersion:               tls.VersionTLS13,
      PreferServerCipherSuites: true,
    },
jmattheis commented 2 years ago

I'd like to keep screego simple, you could use a reverse proxy like nginx to do custom TLS termination.