search

screego / server

screen sharing for developers https://screego.net/
https://app.screego.net
GNU General Public License v3.0
7.76k stars 555 forks source link

Allow configuring a domain name instead of external ip #89

Closed huseyin closed 1 year ago

huseyin commented 3 years ago

We are allowed to indicate the local IP of machine (e.g. 192.168.XX.XX) by default. However, I noticed that we are not able to specify the external IP with 0.0.0.0. 0.0.0.0 means to connect every available interfaces including the loopback as we all know and it is quite useful when it comes to floating IPs. Many of cloud providers tend not to set a public IP statically, which means it can be changed one day. Or, server might be hidden behind a load balancer. It would be great if you could include such a feature, therefore.

jmattheis commented 3 years ago

0.0.0.0 can be used when you want to listen on interfaces. This is already possible to define for the listen addresses:

# The address the http server will listen on.
SCREEGO_SERVER_ADDRESS=0.0.0.0:5050

# The address the TURN server will listen on.
SCREEGO_TURN_ADDRESS=0.0.0.0:3478

https://screego.net/#/config

The IP inside SCREEGO_EXTERNAL_IP will be transmitted to clients, thus it needs to be something specific that can be used outside the server that hosts screego. Technically it would be possible to define a domain there, but I don't think it's worth the effort to implement this.

huseyin commented 3 years ago

I didn't know the concept deeply. Thank you for informing @jmattheis Yeah my second question was that. It may need to solve the domain first and may bring some technical difficulties as you mentioned. I would want to have such a user experience anyway because of the reasons I featured in the issue.

jmattheis commented 3 years ago

Changed this to a feature request.

ZeroDeltaAlpha commented 2 years ago

Just adding a note here that an external address would be great for us as we want o run this in Kubernetes which has no easy mechanism for fetching an external IP

hazzuk commented 1 year ago

Also wanted to add in here that this feature would be extremely helpful. I don't have a static IP, so I would want to provide the config my dynamic DNS.