screenshotbot / screenshotbot-oss

A Screenshot Testing service to tie with your existing Android, iOS and Web screenshot tests
https://screenshotbot.io
Mozilla Public License 2.0
238 stars 13 forks source link

Delete recent runs failed #18

Closed liweijian closed 2 years ago

liweijian commented 2 years ago

As is:

And the network response seems ok.

Request:

DELETE /runs/61fd4d202ed42128e2830632 HTTP/1.1
Host: internal.host
Accept: */*
DNT: 1
X-Requested-With: XMLHttpRequest
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36
Origin: http://internal.host
Referer: http://internal.host/runs
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.9
Cookie: s=CG1RInBsWb61v17OQHwYXsENOUQHVLSo; x_host_key_access=23c6655ad8baaee721fe0b08912419f4e9dd6fc4_s; x-client-ssid=17ecf791c0b-11f9b72560515aba655520de003cc9e2dd88755d
Connection: close

Response:

HTTP/1.1 200 OK
Date: Mon, 07 Feb 2022 03:56:53 GMT
Content-Type: text/html; charset=utf-8
Content-Length: 16
Connection: close
Cache-Control: no-cache
x-forwarded-for: internal.host
x-rio-seq: kzc5xe64-137927557

{"success":true}
tdrhq commented 2 years ago

We currently don't delete promoted runs, but currently it just quietly does nothing. I'll update it so that it gives a notification message. (Internal tracking task: t156)

tdrhq commented 2 years ago

Fixed in https://github.com/screenshotbot/screenshotbot-oss/commit/5c754a5efd4b75563f195da3a3966ca86fa5b0da