screenshotbot / screenshotbot-oss

A Screenshot Testing service to tie with your existing Android, iOS and Web screenshot tests
https://screenshotbot.io
Mozilla Public License 2.0
238 stars 13 forks source link

Broken link in Web console #20

Closed SamCosta1 closed 2 years ago

SamCosta1 commented 2 years ago

Minor issue, but there's a broken link in the web console.

Report created with following:

~/screenshotbot/recorder \
     --directory "./reports/ios_screenshots" \
     --channel "screenshots-test" \
     --main-branch "master" \
     --api-key "<my api key>" \
     --api-secret "<my api secret>" \
     --repo-url "https://bitbucket.org/myorg/org-project.git"

Tapping the following link:

Screenshot 2022-06-13 at 14 59 36

Expected result:

Navigated to: https://bitbucket.org/myorg/org-project.git/commits/e4418358742b8f7c73e980bf631f3222c7e8fcfb

Actual Result

Navigated to: https://bitbucket.org/https:/bitbucket.org/myorg/org-project.git/commit/e4418358742b8f7c73e980bf631f3222c7e8fcfb

It looks as though the base url is getting repeated, and also the path param should be "commits" rather than "commit".

(Though I might well have misconfigured something :) )

tdrhq commented 2 years ago

Oops, let me take a look

tdrhq commented 2 years ago

Fixed!

SamCosta1 commented 2 years ago

Perfect thank you!