Closed SamCosta1 closed 2 years ago
Let me take a look, it does look like something crashed in the Bitbucket logic
For promotion, promotion only happens on the master branch. And there are a bunch of other checks to make sure that a developer doesn't accidentally run a CI script that causes a false promotion.
In your case it looks like the runs on e4418358 detected that the master branch had commit 4dee963a. If e4418 was indeed already committed to master, then this is likely because Bitrise doesn't fetch all the remote branches (I don't exactly remember Bitrise's behaviour, it's been some time since I looked at it). Try adding a git fetch origin master
as a CI step before calling the screenshotbot CLI.
(Separately, I fixed crashes with your pull request notifications. You should now have build statuses that say that the "Base SHA wasn't available for comparison. In those cases it detected the merge base as 14dd4f09. If that is incorrect, it might also be related to not doing the git fetch origin master
step)
I think the issue was the way I was running the test runs, I was doing them locally and in a strange order.
I cleaned a few things up and this is now working! Thank you!
More of a question than an issue.
But how can I promote a run via the cli? I'm currently seeing a list of unpromoted runs in my dashboard but can't see any way to promote one
However there are some errors in the promotion log so possibly this is to do with the fact I'm using bitbucket?