search

screenshotbot / screenshotbot-oss

A Screenshot Testing service to tie with your existing Android, iOS and Web screenshot tests
https://screenshotbot.io
Mozilla Public License 2.0
238 stars 13 forks source link

Fix cli build script #34

Closed petrisorciprian-vitals closed 1 year ago

petrisorciprian-vitals commented 1 year ago

In https://github.com/screenshotbot/screenshotbot-oss/commit/e9f60381f0632699a13e117f3b2d7caa598d369a#diff-9d66d67fdaf638631ee45644b81bbc44983c4060b7a77753c74c6bfaf62e2f79

the main func was split outside of the sdk.lisp file into it's own main.lisp, which broke this build script.

tdrhq commented 1 year ago

Thanks for the patch, I've applied it as https://github.com/screenshotbot/screenshotbot-oss/commit/0744ada143f72680fc18c534596d4ff0c8a1e0a7

(I've merged it outside of GitHub, so it might look like I rejected this PR, but it's already merged)

Separately, I'm also adding this script to our OSS CircleCI builds (we don't use this script internally as you probably figured out)

tdrhq commented 1 year ago

I've also added it to CI to prevent it from breaking: https://github.com/screenshotbot/screenshotbot-oss/commit/279439b99bada4b51250dcf062be1c390b818233