search

screeny05 / letterboxd-list-radarr

Connect radarr to letterboxd.com lists
https://letterboxd-list-radarr.onrender.com
MIT License
285 stars 27 forks source link

Add support for filmographies #6

Closed rfletcher closed 4 years ago

rfletcher commented 4 years ago

Hey, thanks for this project. I stumbled on it a few weeks ago and it's working great.

This PR adds support for Letterboxd filmography pages. (Actor, producer, writer, director, etc.). The important differences between filmography and list pages are:

  1. For whatever reason, there's no data-film-slug attribute in the poster list on these pages. Instead there's data-target-link, which seems to hold the same data. data-target-link is also present on list pages, so I've switched unconditionally.
  2. ~As far as I can tell filmography pages are never paginated (and so .../page/1 is not valid). Tom Hanks, for example, has 117 films listed.~ Edit: Looks like pagination URLs work after all. I've reverted my change here.

This ended up being a very small change, but let me know if you'd like me to make any tweaks.

screeny05 commented 4 years ago

Thank you for your contribution! This has also just been deployed.