Find path opts fixes - Githubissues

screepers / Screeps-Typescript-Declarations

The repository for *Screeps's* TypeScript type definitions.

69 stars 44 forks source link

Find path opts fixes #36

Closed whu-works closed 8 years ago

whu-works commented 8 years ago

Changed PathFinderOps to PathFinderOpts (typo)
Changed Creep.moveTo opts? from PathFinderOpts to FindPathOpts
Changed opts? parameters using FindPathOpts to Intersection instead of Union for:
- Creep.moveTo
- RoomPosition.findClosestByPath
Removed algorithm from opts? for RoomPosition.findInRange (see Room.find)

NhanHo commented 8 years ago

@WHUsoft : your change is right, sorry about the misunderstanding. Tt's an intersection type. Just to double check: is the new typing working for you?

@mschultheiss83: Sorry, I was a bit tired and confused myself yesterday. Apparently I think & is actually appropriate. What is your IDE complaining about?

The reason we want to use & is that we might combine params between different types, like ignoreCreeps and filter in WHUsoft case!.

whu-works commented 8 years ago

@NhanHo No worries :grin: Just tested the latest version (b0920d7258858df292904b137c6fbb857cdf1e5c). It's working for me in visual studio.