Closed katanacrimson closed 3 years ago
It shouldn't be too hard to implement, if steamKeyFile
is specified, set steamKey
to the contents,
As an aside, you can currently pass in the environment variable STEAM_KEY
to avoid it in the config. (I do this for S+ in kubernetes, STEAM_KEY
and a few others like MAPTOOL_PASS
are in a secret that is mounted as environment variables, while the config.yml
is in a configmap)
I'm a big fan of isolating secrets away from configuration. Making secrets available in
docker-compose
(without running docker in swarm mode) is fairly easy, and supporting that feature should be straightforward enough.Proposal: If
steamKeyFile
is specified instead ofsteamKey
, then the exact contents of the file specified insteamKeyFile
should be used.To use this in docker-compose afterwards, the compose file would need to specify a new secret like so:
Pros:
Cons:
steamKey
orsteamKeyFile
should be specified (exclusive or)Unfortunately, I'm not familiar enough with Go, otherwise I'd throw a PR down instead of an issue.