search

screepers / screeps-launcher

Launcher for the Screeps Private Server
MIT License
129 stars 34 forks source link

Add ability to set pinned package versions in config #33

Closed shanemadden closed 1 year ago

shanemadden commented 1 year ago

Add a pinnedPackages config option that's passed through to the resolutions field in package.json.

Some of the upstream packages that are in screeps' dependency chain are starting to release new major versions which drop support for node 12 - without setting some pins, isolated-vm can't build during the yarn build step given the current latest versions of its dependencies on npm.

With this branch's feature plus the following pin configuration, I've gotten the dockerized launcher to successfully complete its yarn build:

pinnedPackages:
  ssri: 8.0.1
  cacache: 16.1.3
AlinaNova21 commented 1 year ago

Hello! Can you please rebase on master to get the circleCI updates? Thta should fix the build and allow me to merge. Thanks!

shanemadden commented 1 year ago

@AlinaNova21 Looks still grumpy unfortunately :(

AlinaNova21 commented 1 year ago

Merged! Build was trying to push to the docker repo on forks, which won't work because credentials. One of these days I'll move it to a GH actions setup and correct that behavior lol

jasonkena commented 1 year ago

passport-steam also needs to be pinned to 1.0.17 since 1.0.18 uses optional chaining, which is not supported by our legacy node versions.

CarsonBurke commented 1 year ago

@AlinaNova21 ^