search

screepers / screeps-multimeter

The most useful tool on your screeps workbench.
MIT License
89 stars 28 forks source link

Fix statusbar watch #17

Closed pyrodogg closed 5 years ago

pyrodogg commented 5 years ago

Fixes api subscription logic Updates memory references to expect in this format { "ok": 1, "data": { "expressions": {}, "values": {} } }

Fixes #16 to work with current screeps-api version 1.7.2

Latest version of screeps-api 1.9.0 also needs screepers/node-screeps-api#46 to be applied

CGamesPlay commented 5 years ago

Hey @pyrodogg, thanks a lot for submitting a PR for this! The code looks great so I will go ahead and merge. I'll go ahead and push a patch version as well.

pyrodogg commented 5 years ago

Thanks for merging!

I realized that screeps-api 1.7.2 was installed during development because of package-lock.json. When installing screeps multimeter globally from npm, there is no package-lock.json so it installs 1.9.0.

So most users will still need to wait for the screeps-api PR to also get merged to really get things working

CGamesPlay commented 5 years ago

Ah, this is a bit confusing: somehow the package ended up with package-lock.json as well as yarn.lock. I will clean that up, the project should use yarn.