NOTE: Branch includes publish-options, so it should not be merged or possibly reviewed until #18 is merged.
Updated ESLint to use the Airbnb typescript base, and the typescript parser so that it can lint .ts files.
Updated the package.json commands to run on the TS files.
Removed a couple of rules which don't work with this project:
"@typescript-eslint/indent": ["error", 4] // Default is '2', not '4'
"import/no-cycle": "off", // There is a cyclic dependency between server and user. It works for now so we can just ignore it.
"lines-between-class-members" // Most classes don't use the extra space
Fixed all existing lint errors in the TS.
Also regenerated yarn.lock, which contributed to the large diff.
--
Note: the airbnb eslint config can be installed without supporting React / TSX tooling. However, this leaves some unresolved peer dependencies which are actually optional. On a fresh yarn install you will see this in the console:
I think it's fine leaving the peers off. They're not necessary, and if the warning is only thrown on initial install it hopefully shouldn't be too confusing to users.
NOTE: Branch includes
publish-options
, so it should not be merged or possibly reviewed until #18 is merged.Updated ESLint to use the Airbnb typescript base, and the typescript parser so that it can lint
.ts
files.Updated the
package.json
commands to run on the TS files.Removed a couple of rules which don't work with this project:
Fixed all existing lint errors in the TS.
Also regenerated
yarn.lock
, which contributed to the large diff.--
Note: the airbnb eslint config can be installed without supporting React / TSX tooling. However, this leaves some unresolved peer dependencies which are actually optional. On a fresh
yarn install
you will see this in the console:We can install these deps to remove these warnings, but the packages will not do anything except bloat the install. Your call.
Install procedures: https://www.npmjs.com/package/eslint-config-airbnb-typescript