search

screepers / screeps-server-mockup

Private server package for unit tests
MIT License
56 stars 13 forks source link

Added comments to import the server from typescript in the examples #21

Closed brisberg closed 4 years ago

brisberg commented 4 years ago

How do you feel about these examples?

These imports don't actually work in as a drop-in in this IIFE, so maybe we need a create two versions of examples? (JS vs TS)

Let me know what you think, I'm not completely satisfied with this PR.

pyrodogg commented 4 years ago

As you mention this probably wouldn't work directly as a drop-in replacement for a Typescript test script. I think we could work on improving this after getting typescript merged into master. As is, this still works fine as a JavaScript test script and the internal Typescript conversion doesn't require consumers to use it.

brisberg commented 4 years ago

Yeah that's basically what I figured. I'll close this for now and we can circle back to examples once TS is merged