search

screepers / screeps-server-mockup

Private server package for unit tests
MIT License
56 stars 13 forks source link

Switching @screeps deps from peer to direct deps #25

Closed brisberg closed 2 years ago

brisberg commented 4 years ago

See #24 for context, just wanted to see how hard it would be to remove the peer dependencies.

These are pinned to the same versions found in @screeps/screeps, though without the launcher, backend, or pathfinding module.

I realized that most of the code for this project is basically reproducing pieces of launcher and engine. See https://github.com/screeps/launcher/blob/master/lib/start.js which looks like our screepsServer.js:start()

Note, I still need to test this by running a real integration test to make sure that the pathfinding module isn't actually required at runtime.

pyrodogg commented 4 years ago

Seems like a reasonable change to clarify how this project is actually structured and making use of the screeps components

pyrodogg commented 4 years ago

Just checked this out again. It looks good to me. Was there any other testing you were thinking of? Pathfinding is a dependency of the engine so not needed explicitly here.

brisberg commented 4 years ago

It looks good to me. I'm ok with merging it :)

brisberg commented 2 years ago

Closing this as it is obsolete