search

screepers / screeps-server-mockup

Private server package for unit tests
MIT License
55 stars 13 forks source link

Test workflow for PRs #38

Closed pyrodogg closed 4 years ago

pyrodogg commented 4 years ago

Testing to see if workflow is now triggered on pull request

pyrodogg commented 4 years ago

As currently configured this runs double tests when for PRs coming from local branches since both the push and pull_request events are getting triggered. This isn't common on this project as most PRs are coming in from forked repositories. External PRs should in theory only trigger the pull_request event.

I'll leave it configured this way for now. Alternatively, it could be restricted to only run on pushes to specific branches (master and typescript) and any pull request. In this case, any pushes to misc other branches wouldn't get immediately validated, and PRs from typescript to master would still get double events.