search

screepers / screeps_notify

Send messages (SMS, Slack) from inside Screeps Scripts
MIT License
23 stars 6 forks source link

Sending "numbers" #7

Open draco2007 opened 6 years ago

draco2007 commented 6 years ago

If I send a message which only includes a number, for example "Notify(Game.time)" the python script crashes here:

https://github.com/screepers/screeps_notify/blob/master/screeps_notify/services/messengers/slack.py#L20

because the function requires a string, but recieves a number. A possible fix would be "str(notification)", which works for strings and numbers. I don't know if the other modules are also affected.

tedivm commented 6 years ago

I do accept pull requests :-)

draco2007 commented 6 years ago

Ok. If I find some time this week I will have a look on it.

I have some more ideas for some features or improvements. Maybe I give it a swing on the weekend =)