search

screeps / grunt-screeps

A Grunt plugin for commiting code to your Screeps account
MIT License
64 stars 36 forks source link

Added server to the options #10

Closed quonic closed 7 years ago

quonic commented 8 years ago

Created a simple option to tie over till full support for private servers.

artch commented 7 years ago

Even if we merge this, note that there is no built-in code uploading support in private servers, and we don't plan to add it. Why would you need this? With private servers, all your scripts are just local files in you Steam client folder, you can simply work with them directly.

OverlordQ commented 7 years ago

Then what does this bit of code do?

tedivm commented 7 years ago

I have to say I would like this as well. I don't want to work on my code "live", so it lives in a different folder than the steam client. When I want to update it I run a grunt command manually, and would like to continue that experience with the private servers.

artch commented 7 years ago

@OverlordQ It deploys to the POST /api/code endpoint, but it uses Steam authentication, there is no built-in password authentication on private servers.

@tedivm Why not to "deploy" to your Steam client folder by simply copying the files when they are ready?

tedivm commented 7 years ago

I actually have a grunt task to do exactly that, but it actually hangs the steam client. Then when I log into the client again it asks me to overwrite my local code (which I obviously don't do). If I had to guess this is related to the size of my codebase (33605 lines, 219 files).

Also, while there is no built in password authentication there is at least one mod out there that adds that feature back in. It's already being used for people who want to do things like add stats collection or use the stand alone console, since both of those require some sort of password.

tedivm commented 7 years ago

Can you please merge this? I literally can not update the private server code right now and would really like to.

Again I tried to do what you said and copy/pasted the files into the appropriate directy, and again the steam client ended up just hanging completely.

tedivm commented 7 years ago

Well, I resolved the issue on my end by switching to an rsync module for the grunt task (so it would only copy changed files, not all of them). I still think this would be a useful feature though.

ross-p commented 7 years ago

I added PR #11 which is a more fully featured version of this change and is confirmed to work with screepsmod-auth

artch commented 7 years ago

Accepted #11, closing this.