screwdriver-cd / screwdriver

An open source build platform designed for continuous delivery.
http://screwdriver.cd
Other
1.01k stars 170 forks source link

Not able to see every template #1279

Open yuichi10 opened 6 years ago

yuichi10 commented 6 years ago

What happened: By this PR template list api return error and cannnot see any templates when there are dangerous shell metacharacters.

What you expected to happen: I think it will be better to not show only unacceptable template info. Not be able to see every template is unconvenient.

How to reproduce it: Before merging this PR, add tempalte which have dangerous shell metacharacters. Then merge this PR.

jithine commented 6 years ago

As a workaround can you delete the offending template from DB. @tkyi can this be handled at API layer ?