search

screwdriver-cd / screwdriver

An open source build platform designed for continuous delivery.
http://screwdriver.cd
Other
1.02k stars 170 forks source link

Hide tooltips that trigger job failed #1497

Open wahapo opened 5 years ago

wahapo commented 5 years ago

What happened: I think we should hide toolTip of prod in case beta not passed. The user may make a mistake to perform a release to prod even though the test is not passed.

sdui-pipeline-failed

What you expected to happen: Tooltips of jobs that can not be executed confidently are not displayed. In the above example, start prod is not recommended unless beta passes.

How to reproduce it: Please see the event of a little old times. https://cd.screwdriver.cd/pipelines/7/events

Related: https://github.com/screwdriver-cd/screwdriver/issues/1335

jithine commented 5 years ago

I am not inclined to make this default. Sometimes if you want to do break fixes you might want to permit this behavior. Perhaps introduce this as annotation such that user can choose to tighten workflow.

say screwdriver.cd/strictWorkflow