search

scribble-rs / ScribblersPad

Scribble.rs Pad is a third party Scribble.rs client that is being developed in the Unity Game Engine.
MIT License
2 stars 0 forks source link

Unclear when namechange is comitted to the server #28

Open Bios-Marcel opened 3 years ago

Bios-Marcel commented 3 years ago

While there's an "Ok" button as soon as you enter the textfield, it seems like leaving the menu is what triggers the namechange. I am wondering whether this could be weird for the player. I'd say it'd be okay to send it to the server right away, it's not that much traffic. This way for example, a player could change his name and directly ask their friends what they think about the name. Now they'd ask and their friends would be confused saying "your name didn't" change.

BigETI commented 3 years ago

So you are suggesting doing name changes while typing? That is absolutely possible.

Bios-Marcel commented 3 years ago

Maybe not after every letter, but with a short delay or on lobby close if it hasn't already been comitted by delay?

BigETI commented 3 years ago

I mean it worked fine when I tested it, you could see in real-time when someone was changing their name.

Bios-Marcel commented 3 years ago

But it's unnecessary spamming, isn't it? I'd prefer to not do that.

BigETI commented 3 years ago

You are showing that in chat, don't you? Then yeah this might be spammy. :D

Bios-Marcel commented 3 years ago

Nah, I am not. I am talking about spamming network requests and causing constant update events on all clients.

But maybe displaying name changes in chat might not be a bad idea xD