scribd / terraform-aws-datadog

Terraform module for setting up AWS Datadog integration
https://registry.terraform.io/modules/scribd/datadog/aws/1.0.0
MIT License
38 stars 30 forks source link

doc: fix full integration example #16

Closed houqp closed 4 years ago

jim80net commented 4 years ago

If I'm understanding the PR, seems that the datadog_app_key is only needed for the datadog provider (https://registry.terraform.io/providers/DataDog/datadog/latest/docs), which is out of scope of the module. The module itself only technically needs the api key.

Do I understand the thinking correctly?

houqp commented 4 years ago

That's right, that's a provider config, not sure how it got into the module invocation. Terraform modules are not supposed to provision providers.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.3.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: