scribd / terraform-aws-datadog

Terraform module for setting up AWS Datadog integration
https://registry.terraform.io/modules/scribd/datadog/aws/1.0.0
MIT License
38 stars 30 forks source link

Enable supplying arbitrary tags #4

Open jim80net opened 4 years ago

jim80net commented 4 years ago

I want to supply a tags parameter with an arbitrary map of tags, potentially eliminating the hard coded Namespace and Env parameters. So that I don't have to be limited by only env and namespace.

Given we've already an expectation to support these parameters, perhaps in implementation we can simply add tags, and deprecate the namespace and env parameters until users have converged on the new mechanism.

houqp commented 4 years ago

I like the idea of supporting arbitrary map of tags as well. Only question I have is if we remove special tags like namespace and env, how should we generate unique name for resources. Adding all the tags to the name can easily cause errors like exceeding max length constraint.

Perhaps a middle ground is to support arbitrary map of tags but keep namespace and env as special tags that will be used for constructing unique ids and names?

Art3mK commented 4 years ago

btw, what is that namespace tag? I've never used datadog before, but can't find any namespace tag mention in their documentation, why it's special? What it's used for? To distinguish different AWS accounts and their metrics?

and uniq names could be generated using random provider in tf.

houqp commented 4 years ago

@Art3mK this is for human readable prefixes, we also use it to tag resources for each individual teams since each team has its own AWS account.