scribd / terraform-aws-datadog

Terraform module for setting up AWS Datadog integration
https://registry.terraform.io/modules/scribd/datadog/aws/1.0.0
MIT License
38 stars 30 forks source link

feat!: enable support for aws provider 4.0+ #49

Closed kuntalkumarbasu closed 2 years ago

kuntalkumarbasu commented 2 years ago

This should fix https://github.com/scribd/terraform-aws-datadog/issues/43 BREAKING CHANGE Based on the below understanding , I think we do not need to do manual import in most of the cases. However we should create a major version though.

Each of the new aws_s3bucket resources relies on S3 API calls that utilize a PUT action in order to modify the target S3 bucket. Because these API calls adhere to standard HTTP methods for REST APIs, they should handle situations where the target configuration already exists (as noted in the HTTP RFC). Given that this is the case, it's not strictly necessary to import any new aws_s3bucket resources that are a one-to-one translation from previous versions of the AWS provider -- on the next terraform apply, they'll attempt the PUT, and update the state with the results as necessary. There is, however, a downside to this approach in that the diff will show each of the new resources as needing to be created.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: