search

scribd / terraform-aws-datadog

Terraform module for setting up AWS Datadog integration
https://registry.terraform.io/modules/scribd/datadog/aws/1.0.0
MIT License
38 stars 30 forks source link

feat: enable support for Terraform 1.3.x #51

Closed miend closed 1 year ago

miend commented 2 years ago

Using Terraform 1.3.2, this module seems to work just as expected, all resources created fine. I can see no breaking changes between tf 1.2 and 1.3 which should affect this. This will relax the requirements to allow any 1.3.x to be used.

miend commented 2 years ago

A ping for review by @jim80net -- thanks :+1:

nogweii commented 1 year ago

We're running into this, too. Friendly ping to someone at Scribd. 😄

call commented 1 year ago

Yes please, can we get this merged Scribd team 🙏 Thank you. cc @jim80net

jim80net commented 1 year ago

Apologies for the delay in merge. Thanks everyone for your submission and comments!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dtw45 commented 1 year ago

Hey @jim80net, it's pretty uncommon for modules to specify a cap on the required Terraform version, normally they only enforce a minimum. (Any of the aws managed Terraform modules should serve as an example)

Specifying a cap blocks users from upgrading to newer versions and requires that these small PRs are opened and reviewed every time a new version of Terraform is released. Would you guys consider only enforcing a minimum?