scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
40 stars 38 forks source link

Expand keyboard installation instructions on installation screen #113

Closed andrewtavis closed 1 month ago

andrewtavis commented 1 month ago

Terms

Description

As of writing the Installation screen of the application has ENABLE KEYBOARD as the title of the button to select the keyboard. The current state is shown below:

Screenshot 2024-09-14 at 19 42 10

We'd like to expand this with more detailed directions for the user as seen on the designs on Figma and below:

Keyboard Installation - Light

The strings needed for this are:

Included in this would also be adding in the settings cog icon on the upper right corner of the option as is done in the privacy policy page and third party likenesses :)

Contribution

Happy to discuss this with someone and review or also get to it myself eventually šŸ˜Š

andrewtavis commented 1 month ago

@Linfye, I'm thinking that this could be a pretty straightforward issue for you given your work to add in the other pages with the upper right icons? Would you like to work on this one?

andrewtavis commented 1 month ago

Looking into #119 at the same time might also make sense, as the functionality of the button will change from enabling a keyboard to selecting keyboards to install, which is handled in #119 :) :)

Linfye commented 1 month ago

Iā€™m happy to do this, but Iā€™m a bit busy at the moment. I might only be able to work on Scribe in about two weeks, is that okay?

andrewtavis commented 1 month ago

100% ok, @Linfye :) I won't assign you for now so it's not on your to do list, but please let us know when you have more availability!

Linfye commented 1 month ago

@andrewtavis I am working on this. You can assign me this now. šŸ˜Š

Linfye commented 1 month ago

I'm not quite clear about three things:

  1. Does the "Open Scribe settings" with the underline also function like the "settings" at the bottom of the interface to navigate to "Settings" page?

  2. How should I use the "Download data" option? Does it require fetching some data from a server?

  3. Is the "Quick tutorial" a button (it looks like a button to me)? If so, what page should it open?

Thanks. :)

andrewtavis commented 1 month ago

Hey @Linfye! Answers to your questions:

  1. The button for keyboard installation will open the keyboard installation settings for the device. So once you click the button you will be able to install Scribe keyboards, rather than selecting a Scribe keyboard. Specifically it's doing what the user is forced to do by the alert when the app is first installed - install a Scribe keyboard. In this case it's also not "Open Scribe settings" but rather "Open keyboard settings", which is the value of the first i18n key listed above - app.installation.keyboard.keyboard_settings :)

  2. No need to worry about the data download for this issue!

  3. Also no need to worry about the tutorial! Sorry, I should have just done a screenshot of the keyboard installation directions :)

Let me know if I can help any other way!

andrewtavis commented 1 month ago

Note that we also need the header above the white background for this as is the style of other sections in the app, so "Keyboard installation" should be above the new directions as shown in the image.

andrewtavis commented 1 month ago

See #199 for the other part of this, @Linfye. As of now the user is forced to install a keyboard on first load of an app. After these two issues the user will not be forced to install a keyboard via #119, will be prompted to install a keyboard via the "Open keyboard directions" description on the installation page via the work for this issue, and the settings tab will also prompt the user to install a keyboard with a button if the user has not as part of #119, with this button similarly opening the keyboard settings of the device šŸ˜Š

andrewtavis commented 1 month ago

Closed by #140 šŸ˜Š Thanks for being such a great part of the team, @Linfye!