Keyboard UI coloration fixes

scribe-org / Scribe-Android

Android app with keyboards for language learners

GNU General Public License v3.0

29 stars 15 forks source link

Keyboard UI coloration fixes #121

Open andrewtavis opened 4 days ago

andrewtavis commented 4 days ago

Terms

[X] I have searched open and closed design issues
[X] I agree to follow Scribe-Android's Code of Conduct

Description

This issue would fix a few issues with the keyboard coloration. The current Scribe-Android keyboard is shown below:

Changes that are needed are:

We want the shift key, ?123 key, backspace key and return key to be the special key color
- Ideally the return key would be the current blue when the command bar is present once one of the Translate, Conjugate or Plural options is pressed
It would be good for the background of the area where the Scribe key and autosuggestions are to be the same color as the rest of the keyboard
The autosuggestions should not have a distinct background to the rest of the keyboard (i.e. their background should be clear)

Contribution

Happy to support with this and review when all's ready! Can also get to it myself eventually :) :)

angrezichatterbox commented 2 days ago

I will work on this issue.

andrewtavis commented 2 days ago

Thanks @angrezichatterbox! Let me know if another call before Hacktoberfest to discuss the project could help. We're getting into a phase where larger issues like implementing commands will start being worked on, and it would likely make sense to plan those out before making them 😊

angrezichatterbox commented 2 days ago

Thanks @angrezichatterbox! Let me know if another call before Hacktoberfest to discuss the project could help. We're getting into a phase where larger issues like implementing commands will start being worked on, and it would likely make sense to plan those out before making them 😊

Yes it would be helpful for a call. As I too would like to know what would be worked on next and how is it being planned.

andrewtavis commented 2 days ago

Let me know when would work for you on Element :) I can do Friday after work or the weekend when it's not too late for you 😊

angrezichatterbox commented 1 hour ago

We want the shift key, ?123 key, backspace key and return key to be the special key color

Could I get some idea on what the special key color means. Return key should change color accordingly to state like idle state means it would be the usual dark and white color and for other states we would have scribe blue color. What should be done about the ?123 and backspace.

andrewtavis commented 50 minutes ago

Definitely could have been more clear here :) So if you check Scribe-iOS, keySpecial.colorset is the one that I'm talking about for the special key colors, and keyPressed.colorset is what we'll use for the shift key being pressed. If any of the colors within Assets.xcassets/Colors is missing in Android, then it might make sense to add them in this issue as well 🎨😊

andrewtavis commented 48 minutes ago

Basically the special keys as listed above are a bit more grey than the normal keys, but the key pressed color is consistent for each (except for Scribe blue colored keys, but we'll get to those later).