search

scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
29 stars 14 forks source link

Add double space period shortcut #20

Closed andrewtavis closed 2 months ago

andrewtavis commented 2 years ago

Terms

Description

The double space period shortcut will need to be added to Scribe-Android before the initial release, as this is a valuable technique that users will expect. This issue is for finding where it should be added and implementing the change.

Ideally this would also include an option in the settings to disable this feature, but this can be done later in another issue.

Contribution

I'll work on this if others don't have interest. This should definitely be included in the 1.0.0 release.

Jk40git commented 6 months ago

@andrewtavis I have interest on this 👍 !

andrewtavis commented 6 months ago

Hey @Jk40git 👋 Great to hear that you have interest in Scribe-Android :) For now let's stick to Scribe-Data as we're not really focussing here right now, and the goal of GSoC is to work on Scribe-Data.

Jk40git commented 6 months ago

Hey @Jk40git 👋 Great to hear that you have interest in Scribe-Android :) For now let's stick to Scribe-Data as we're not really focussing here right now, and the goal of GSoC is to work on Scribe-Data.

All right 👍

angrezichatterbox commented 3 months ago

Could I work on this issue and is it still available to be solved or is it already solved ?

andrewtavis commented 3 months ago

Sure thing, @angrezichatterbox! Let me know if there's anything I can do to support :)

angrezichatterbox commented 3 months ago

I have made the double space period shortcut should I also add the option in settings to disable and enable this shortcut before creating a pull request

andrewtavis commented 3 months ago

Ya that'd be perfect, @angrezichatterbox! Thanks for checking in and going the extra mile!

angrezichatterbox commented 3 months ago

I have implement the period on checkbox enabling only . I have one doubt the period should only come when there is text before the double tap on space bar right

andrewtavis commented 3 months ago

Yes, that sounds great, @angrezichatterbox!

angrezichatterbox commented 3 months ago

Is there any function to check for text before cursor or I have to make one by using the input connection in SimpleKeyboardIME.KT.

andrewtavis commented 3 months ago

I think you'd need to make the function yourself. And that file should be renamed as well given that it's related to the project that Scribe Android is based on :)

angrezichatterbox commented 3 months ago

I have created a pull request adding this feature do check it whenever you're free . I am ready to make changes as required.

andrewtavis commented 3 months ago

Thanks, @angrezichatterbox! Will check this and the other PR as soon as I can :)

andrewtavis commented 2 months ago

Closed by #36 😊 Thanks a lot for this, @angrezichatterbox! Really great to have a feature in here after so long. I'm set up to be able to review now, so feel free to work on stuff. Maybe from here you can provide some feedback on #34, and then after that we can look to do a call if you'd still like to work on things?

Again, thanks so much!