scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
41 stars 40 forks source link

Fix Magic Number Issues #234

Closed Linfye closed 3 weeks ago

Linfye commented 3 weeks ago

Contributor checklist


Description

Thanks to the previous contributors for their refactoring work, which removed a lot of unnecessary code. I only need to modify about 50 formatting errors instead of the 500 I mentioned in #90. 😊

Related issue

github-actions[bot] commented 3 weeks ago

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

andrewtavis commented 3 weeks ago

We're really making some great progress 😊