search

scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
41 stars 40 forks source link

Setup Slack Compose Lint Check for Better Migration from XML to Compose #240

Closed angrezichatterbox closed 1 week ago

angrezichatterbox commented 1 week ago

Terms

Description

To ensure the migration from XML to Jetpack Compose follows best practices, we need to integrate a Compose lint check. This will help identify issues early and ensure the code adheres to recommended guidelines. The task involves adding the required dependency for Slack Compose Lint Check and a gradle task to be associated with it.

If there are lining issues that arise after the addition of the lint checks Subsequent issues could be created if the linting issues are large or if small could be fixed within the same issue.

Contribution

Happy to help anyone solve this issue or take this up myself at some point :)

MahmoudMabrok commented 1 week ago

@angrezichatterbox Could you elaborate more about 

If there are lining issues that arise after the addition of the lint checks Subsequent issues could be created if the linting issues are large or if small could be fixed within the same issue.
angrezichatterbox commented 1 week ago

So currently a single page has been converted to Compose and We don't expect a lot of linting issues for the Compose page However if linting issues exist and there are a lot of them Issues could be created to fix them. If there are one two linting issues It could be fixed while the Linting for Compose is setup.

angrezichatterbox commented 1 week ago

I will be working on this issue :)

andrewtavis commented 1 week ago

Thanks for taking this on, @angrezichatterbox!

angrezichatterbox commented 1 week ago

Could we use N Lopez Compose Rules? It is a fork of the Twitter compose rules and is actively being maintained. An advantage of using this would be that we could easily link it with the existing detekt and ktlint tasks and the ruleset is same to the slack compose one.

andrewtavis commented 1 week ago

That works for me, yes :) Thanks for the research, @angrezichatterbox!

andrewtavis commented 1 week ago

Closed by #242 :) Amazing to be making so much progress in these regards, @angrezichatterbox! Really looking forward to the next steps and getting the app onto Compose completely 😊