search

scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
27 stars 14 forks source link

added default theme setting #33

Closed ayushanand308 closed 1 year ago

ayushanand308 commented 1 year ago

Only did a very minor change to set the default theme of the app to system's default theme.

andrewtavis commented 1 year ago

Hey @ayushanand308 👋 The option to select dark theme is showing up on the branch for me when I load it in Android Studio, but I'm not seeing a change in the theme when I select dark mode in the settings or when I select it in the menu option 🤔

Do you have any thoughts on how I can get the changes showing up on an Android Studio emulator?

Thanks, and hope you're well!

ayushanand308 commented 1 year ago

Actually only the functionality of changing theme according to user's default theme was added as you asked for that feature as well. I was not able to figure out a way to make the theme change when the dark theme check box is checked and I am still trying for that. Any help or feedback will be appreciated.

andrewtavis commented 1 year ago

Hmmm, interesting 🤔 Even when I change my default theme it's not changing though 🤔 I saw in your video that it is working, but then it doesn't seem to be working on my end. What device/emulator are you using?

ayushanand308 commented 1 year ago

@andrewtavis I am using Xiaomi Redmi 9.

andrewtavis commented 1 year ago

I’ll try on that one and see if the change goes though. Thanks, @ayushanand308!