scribe-org / Scribe-Android

Android app with keyboards for language learners
GNU General Public License v3.0
27 stars 14 forks source link

feat:Added a shadow beneath the key #35

Closed angrezichatterbox closed 2 months ago

andrewtavis commented 2 months ago

Finally able to test this a bit, @angrezichatterbox :) So generally it's working, but the space bar being made smaller by padding isn't ideal. Ideally we could get these keys looking like the iOS ones with rounding and a bit of space between the keys. Do you think that that would be possible? We can also hold off on the edits until you're done with the research in #34 :)

angrezichatterbox commented 2 months ago

Ok I will fix it after I look into the AOSP keyboard and will also look into the other issues ..

andrewtavis commented 2 months ago

Sounds great, @angrezichatterbox! Let me know if you want to discuss things at some point :)

angrezichatterbox commented 2 months ago

I am free to discuss any changes that is required to be made in this project .

andrewtavis commented 2 months ago

Sounds great :) Let's check in maybe once you have some thoughts on #34!

angrezichatterbox commented 2 months ago

Sorry for the delay in checking and fixing the issues as well the AOSP thing I had exams I will return to correcting those from tmrw

andrewtavis commented 2 months ago

100% ok, @angrezichatterbox! Good luck with exams :)

angrezichatterbox commented 2 months ago

I have made some changes to the code and made the keys more rounded also I fixed the issue of space bar having rounded white curbed rectangle in between.